Copilot commented on code in PR #53127:
URL: https://github.com/apache/spark/pull/53127#discussion_r2541069582
##########
core/src/main/resources/org/apache/spark/ui/static/webui.css:
##########
@@ -30,13 +30,14 @@ h4 {
}
a,
-a:not([href]) {
+a:not([href]):not([class]) {
color: #0088cc;
text-decoration: none;
}
Review Comment:
The CSS selector change adds `:not([class])` to anchor tags without href
attributes. This means styled anchor elements with classes (like Bootstrap's
button classes) will no longer receive these base styles. Verify that this
doesn't inadvertently break existing UI components that rely on these base
anchor styles, particularly Bootstrap components that may have been added or
changed in v4.6.2.
##########
core/src/main/scala/org/apache/spark/ui/UIUtils.scala:
##########
@@ -461,17 +461,19 @@ private[spark] object UIUtils extends Logging {
if (skipped > 0) s" ($skipped skipped)" else ""
} + killTaskReasonText
+ // scalastyle:off line.size.limit
<div class="progress">
- <span style="text-align:center; position:absolute; width:100%;"
title={progressTitle}>
- {completed}/{total}
- { if (failed == 0 && skipped == 0 && started > 0) s"($started
running)" }
- { if (failed > 0) s"($failed failed)" }
- { if (skipped > 0) s"($skipped skipped)" }
- { killTaskReasonText }
+ <span style="text-align:center; position:absolute; width:100%;
height:100%; align-content: center" title={progressTitle}>
Review Comment:
The inline style uses `align-content: center` which may not be supported in
all browsers for this use case. Consider using `display: flex; align-items:
center; justify-content: center` for more reliable cross-browser vertical
centering, or ensure the target Bootstrap v4.6.2 properly supports this
property for the intended layout.
```suggestion
<span style="display: flex; align-items: center; justify-content:
center; position:absolute; width:100%; height:100%; text-align:center;"
title={progressTitle}>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
