zhengruifeng commented on PR #53113: URL: https://github.com/apache/spark/pull/53113#issuecomment-3560745177
> `NotImplementedError` is a bit too strict I agree - if we designed it from scratch that might be the way to go. How about return `self is other`? Do we have a lot of use case where we need to compare > > ```python > type1 = Vector(3) > type2 = Vector(3) > assert type1 == type2 > ``` @gaogaotiantian We can modify the builtin UDTs (VectorUDT/MatrixUDT/etc) but I am not sure whether `__eq__` is used a lot in user code. I think we can revisit it in a separate thread/PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
