holdenk commented on code in PR #52968:
URL: https://github.com/apache/spark/pull/52968#discussion_r2548186001
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortAggregateExec.scala:
##########
@@ -87,6 +92,8 @@ case class SortAggregateExec(
outputIter
}
}
+ aggTime += NANOSECONDS.toMillis(System.nanoTime() - beforeAgg)
Review Comment:
So I think the difference is the `TungstenAggregationIterator` is not as
lazy -- during it's init step it does the aggregation and whereas
`sortbasedaggregationiterator` does the compute mostly inside of `next`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
