LuciferYang commented on code in PR #53139:
URL: https://github.com/apache/spark/pull/53139#discussion_r2548761180
##########
sql/hive-thriftserver/src/test/resources/log4j2.properties:
##########
@@ -27,10 +27,8 @@ appender.console.target = SYSTEM_OUT
appender.console.layout.type = PatternLayout
appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c:
%maxLen{%m}{512}%n%ex{8}%n
-appender.console.filter.1.type = Filters
-
-appender.console.filter.1.a.type = ThresholdFilter
-appender.console.filter.1.a.level = warn
+appender.console.filter.1.type = ThresholdFilter
+appender.console.filter.1.level = warn
Review Comment:
I attempted to modify it to
```
diff --git a/sql/hive-thriftserver/src/test/resources/log4j2.properties
b/sql/hive-thriftserver/src/test/resources/log4j2.properties
index 3ad0c902283..db61ac18aee 100644
--- a/sql/hive-thriftserver/src/test/resources/log4j2.properties
+++ b/sql/hive-thriftserver/src/test/resources/log4j2.properties
@@ -29,8 +29,8 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c:
%maxLen{%m}{512}%n%ex{
appender.console.filter.1.type = Filters
-appender.console.filter.1.a.type = ThresholdFilter
-appender.console.filter.1.a.level = warn
+appender.console.filter.threshold.type = ThresholdFilter
+appender.console.filter.threshold.level = warn
#File Appender
appender.file.type = File
@@ -41,8 +41,8 @@ appender.file.layout.pattern = %d{HH:mm:ss.SSS} %t %p
%c{1}: %m%n%ex
appender.file.filter.1.type = Filters
-appender.file.filter.1.a.type = ThresholdFilter
-appender.file.filter.1.a.level = debug
+appender.file.filter.threshold.type = ThresholdFilter
+appender.file.filter.threshold.level = debug
```
then run `build/sbt -Phive -Phive-thriftserver "hive-thriftserver/test"`
```
[warn] note: a setting might still be used by a command; to exclude a key
from this `lintUnused` check
[warn] either append it to `Global / excludeLintKeys` or call
.withRank(KeyRanks.Invisible) on the key
[warn] multiple main classes detected: run 'show discoveredMainClasses' to
see the list
[warn] multiple main classes detected: run 'show discoveredMainClasses' to
see the list
WARNING: Using incubator modules: jdk.incubator.vector
WARNING: Using incubator modules: jdk.incubator.vector
WARNING: Using incubator modules: jdk.incubator.vector
WARNING: Using incubator modules: jdk.incubator.vector
2025-11-21T07:04:45.182733Z pool-1-thread-1 ERROR Filters contains invalid
attributes "onMatch", "onMismatch"
2025-11-21T07:04:45.316967Z pool-1-thread-1 ERROR appender Console has no
parameter that matches element ThresholdFilter
2025-11-21T07:04:45.323364Z pool-1-thread-1 ERROR Filters contains invalid
attributes "onMatch", "onMismatch"
2025-11-21T07:04:45.325055Z pool-1-thread-1 ERROR appender File has no
parameter that matches element ThresholdFilter
2025-11-21T07:04:45.349702Z pool-1-thread-1 ERROR Filters contains invalid
attributes "onMatch", "onMismatch"
2025-11-21T07:04:45.484934Z pool-1-thread-1 ERROR appender Console has no
parameter that matches element ThresholdFilter
2025-11-21T07:04:45.491476Z pool-1-thread-1 ERROR Filters contains invalid
attributes "onMatch", "onMismatch"
2025-11-21T07:04:45.503621Z pool-1-thread-1 ERROR appender File has no
parameter that matches element ThresholdFilter
[info] SparkSQLEnvSuite:
2025-11-21T07:04:45.661128Z pool-1-thread-1 ERROR Filters contains invalid
attributes "onMatch", "onMismatch"
2025-11-21T07:04:45.686623Z pool-1-thread-1 ERROR appender Console has no
parameter that matches element ThresholdFilter
2025-11-21T07:04:45.717872Z pool-1-thread-1 ERROR Filters contains invalid
attributes "onMatch", "onMismatch"
2025-11-21T07:04:45.746474Z pool-1-thread-1 ERROR appender Console has no
parameter that matches element ThresholdFilter
2025-11-21T07:04:45.754913Z pool-1-thread-1 ERROR Filters contains invalid
attributes "onMatch", "onMismatch"
2025-11-21T07:04:45.820345Z pool-1-thread-1 ERROR appender File has no
parameter that matches element ThresholdFilter
2025-11-21T07:04:45.821849Z pool-1-thread-1 ERROR Filters contains invalid
attributes "onMatch", "onMismatch"
2025-11-21T07:04:45.830148Z pool-1-thread-1 ERROR appender File has no
parameter that matches element ThresholdFilter
```
It seems the goal hasn't been achieved. What's your opinion on this?
@yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
