dongjoon-hyun commented on code in PR #53173:
URL: https://github.com/apache/spark/pull/53173#discussion_r2553504016
##########
sql/core/src/main/scala/org/apache/spark/sql/classic/DataFrameWriter.scala:
##########
@@ -484,12 +484,50 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) extends sql.DataFram
serde = None,
external = false,
constraints = Seq.empty)
+ val writeOptions = if (source == "delta") {
Review Comment:
Does Apache Spark source code have this kind `delta`-specific logic before,
@juliuszsompolski ?
This looks like the first proposal to have a 3rd-party company data source
in Apache Spark source code. At the first glance, this string match looks a
little fragile to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
