dongjoon-hyun commented on code in PR #53205:
URL: https://github.com/apache/spark/pull/53205#discussion_r2558584503
##########
python/pyspark/sql/pandas/types.py:
##########
@@ -855,6 +856,7 @@ def _to_corrected_pandas_type(dt: DataType) ->
Optional[Any]:
return None
[email protected]_cache(maxsize=64)
Review Comment:
Nice!
BTW, this looks like a magic number to me. May I ask why `maxsize` is `64`?
> to simplify the caching, also to control the cache size
Is this a regression because previously `_converter_cache` is unlimited like
`@cache`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
