cloud-fan commented on code in PR #53164:
URL: https://github.com/apache/spark/pull/53164#discussion_r2559003433


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##########
@@ -480,7 +480,8 @@ object ResolveDefaultColumns extends QueryErrorsBase
     val ret = analyzed match {
       case equivalent if equivalent.dataType == supplanted =>
         equivalent
-      case canUpCast if Cast.canUpCast(canUpCast.dataType, supplanted) =>
+      case canAssignDefaultValue
+        if Cast.canAssignDefaultValue(canAssignDefaultValue.dataType, 
supplanted) =>

Review Comment:
   ```suggestion
         case _ if Cast.canAssignDefaultValue(analyzed.dataType, supplanted) =>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to