holdenk commented on PR #52576: URL: https://github.com/apache/spark/pull/52576#issuecomment-3576905833
The implicit conversion being avoided was from your PR description. So the goal is to remove an intermediary array allocation, and now that you've removed the repeated calls which were introduced in the first version (likely allocating more arrays than before) I can see this potentially being better. We still alloc an array for the input elems but we avoid an array for the eval result correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
