cloud-fan commented on code in PR #53215: URL: https://github.com/apache/spark/pull/53215#discussion_r2562481729
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/RequiresDataFrameWriterV1SaveAsTableOverwriteWriteOption.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.catalog; + +import org.apache.spark.annotation.Evolving; + +/** + * A marker interface that can be mixed into a {@link TableProvider} to indicate that the data + * source needs to distinguish between DataFrameWriter V1 {@code saveAsTable} operations and + * DataFrameWriter V2 {@code createOrReplace}/{@code replace} operations. + * <p> + * Background: DataFrameWriter V1's {@code saveAsTable} with {@code SaveMode.Overwrite} creates + * a {@code ReplaceTableAsSelect} logical plan, which is identical to the plan created by Review Comment: ```suggestion * a {@code ReplaceTableAsSelect} logical plan if the table is V2, which is identical to the plan created by ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
