holdenk commented on code in PR #53022:
URL: https://github.com/apache/spark/pull/53022#discussion_r2566878201
##########
core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala:
##########
@@ -503,25 +504,33 @@ class ExecutorSuite extends SparkFunSuite
e: => Throwable,
depthToCheck: Int,
isFatal: Boolean): Unit = {
- import Executor.isFatalError
+
+ class BeEqualToIsFatal(isFatal: Boolean) extends Matcher[Throwable] {
Review Comment:
So the usage of this is to see if an error is a fatal error or not
(depending on the boolean flag passed in) right? shouldBeFatalError(true or
false) makes a bit more sense to be me from a naming point of view, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
