pan3793 commented on PR #53252: URL: https://github.com/apache/spark/pull/53252#issuecomment-3587795074
@vinodkc thanks for making a followup. > Semantic correctness: Types.VARBINARY (variable-length) better matches Spark's BinaryType semantics. fully agree. but for length, I may not be clear in [my previous comments](https://github.com/apache/spark/pull/53018#discussion_r2521745670). I think in this case, we'd better use `Int.MaxValue` for both StringType and BinaryType, this is also same as current Hive JDBC behavior. https://github.com/apache/hive/blob/rel/release-2.3.10/jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java#L230-L234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
