mihailoale-db commented on PR #53268: URL: https://github.com/apache/spark/pull/53268#issuecomment-3599502480
we did the same (overriding `equals` and `hashCode`) here https://github.com/apache/spark/pull/50454 and here https://github.com/apache/spark/pull/50212 so it felt straightforward to just follow those examples. I wonder if making them case classes could somehow backfire? Is it the best practice? If not, I would keep it as it is if you agree. cc @HyukjinKwon @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
