pan3793 commented on code in PR #53261:
URL: https://github.com/apache/spark/pull/53261#discussion_r2579368832
##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/test/RemoteSparkSession.scala:
##########
@@ -93,6 +93,11 @@ object SparkConnectServerUtils {
if (isDebug) {
builder.redirectError(Redirect.INHERIT)
builder.redirectOutput(Redirect.INHERIT)
+ } else {
+ // If output is not consumed, the stdout/stderr pipe buffers will fill
up,
+ // causing the server process to block on write() calls
Review Comment:
I think the original intention here is to redirect sub-process logs (via
`Redirect.INHERIT` because the parent process respects log4j config) only when
`debug` is on.
But actually, I always enable the `debug` flag in my local dev env ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
