pan3793 commented on code in PR #52978:
URL: https://github.com/apache/spark/pull/52978#discussion_r2579395234
##########
project/SparkBuild.scala:
##########
@@ -1177,12 +1178,33 @@ object KubernetesIntegrationTests {
)
}
+object DependencyVersions {
Review Comment:
code refactoring suggestions were almost ignored, I'd like to see the
technical explanation when doing that.
here are my thoughts behind the suggestions:
- rename var `jacksonModuleID` => `jacksonBom`, the `ModuleID(...)` already
indicates the var type, what is important here is `bom`
- merge `getVersion` and `getVersionFromPom` to `getProperty` - it's
overengineering, also disturbs IDE search functionality, when something goes
wrong, or users want to understand where `fasterxml.jackson.version` is used,
it's likely to do a global search
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
