cloud-fan commented on code in PR #53245:
URL: https://github.com/apache/spark/pull/53245#discussion_r2579563849
##########
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala:
##########
@@ -193,6 +193,14 @@ final class ShuffleBlockFetcherIterator(
initialize()
+ private def incFetchWaitTime[T](f: () => T): Unit = {
+ val startFetchWait = System.nanoTime()
+ val t = f()
+ val fetchWaitTime = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startFetchWait)
+ shuffleMetrics.incFetchWaitTime(fetchWaitTime)
+ return t
Review Comment:
```suggestion
t
```
##########
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala:
##########
@@ -193,6 +193,14 @@ final class ShuffleBlockFetcherIterator(
initialize()
+ private def incFetchWaitTime[T](f: () => T): Unit = {
+ val startFetchWait = System.nanoTime()
+ val t = f()
Review Comment:
```suggestion
val res = f()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
