VindhyaG commented on code in PR #53272:
URL: https://github.com/apache/spark/pull/53272#discussion_r2579601760
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala:
##########
@@ -520,9 +520,41 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
def subqueries: Seq[PlanType] = _subqueries()
private val _subqueries = new TransientBestEffortLazyVal(() =>
- expressions.filter(_.containsPattern(PLAN_EXPRESSION)).flatMap(_.collect {
- case e: PlanExpression[_] => e.plan.asInstanceOf[PlanType]
- })
Review Comment:
As far as I understand, the earlier logic did not return None in case there
were any subqueries regardless of the plantype. Now we do have a chance of
empty sequence to be returned right? If so, should we not have UTs for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
