sarutak commented on code in PR #53267:
URL: https://github.com/apache/spark/pull/53267#discussion_r2581948691
##########
core/src/main/scala/org/apache/spark/internal/config/UI.scala:
##########
@@ -58,6 +58,7 @@ private[spark] object UI {
val UI_ALLOW_FRAMING_FROM = ConfigBuilder("spark.ui.allowFramingFrom")
.version("1.6.0")
.stringConf
+ .checkValue(s => !s.contains("\n"), "Newlines are not allowed due to
security concerns")
Review Comment:
Should we consider `\r` too because we can write `\u000d` in
`spark-defaults.conf`?
Also, do we need to consider `spark.ui.xXssProtection` and
`spark.ui.strictTransportSecurity` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
