szehon-ho commented on code in PR #53227:
URL: https://github.com/apache/spark/pull/53227#discussion_r2583344576


##########
dev/checkstyle-suppressions.xml:
##########
@@ -50,6 +50,8 @@
               
files="src/main/java/org/apache/spark/examples/JavaLogQuery.java"/>
     <suppress checks="LineLength"
               files="src/main/java/org/apache/hive/service/*"/>
+    <suppress checks="LineLength"
+              
files="sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/util/WkbReaderWriterTest.java"/>

Review Comment:
   @dongjoon-hyun i tried a little bit but couldn't get it to work by 
   ```
   // checkstyle.off: LineLength
   code
   // checkstyle.on: LineLength
   ```
   
   I took a little look into it, I think 
[LineLength](https://github.com/apache/spark/blob/master/dev/checkstyle.xml#L67)
 is not able to be handled by the 
[TreeWalker](https://github.com/apache/spark/blob/master/dev/checkstyle.xml#L67)
 that usually handles that rule.  It's more line by line.  So i edited the 
checkstyle.xml to add that annotation, wdyt?
   
   This is a problem for java files only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to