caldempsey commented on code in PR #167:
URL: https://github.com/apache/spark-connect-go/pull/167#discussion_r2586221311
##########
spark/sql/dataframewriter.go:
##########
@@ -48,6 +50,7 @@ type dataFrameWriterImpl struct {
relation *proto.Relation
saveMode string
formatSource string
+ options map[string]string
Review Comment:
This might work better as an array. The map structure offers fast lookups,
but given the expected number of options, the complexity improvement won't make
a meaningful difference. The bigger concern is that iteration order isn't
guaranteed with maps, so you could get different orderings each time you loop
through the items.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
