dongjoon-hyun commented on code in PR #53341:
URL: https://github.com/apache/spark/pull/53341#discussion_r2593538284
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/AbstractFetchShuffleBlocks.java:
##########
@@ -44,15 +42,6 @@ protected AbstractFetchShuffleBlocks(
this.shuffleId = shuffleId;
}
- // checkstyle.off: RegexpSinglelineJava
- public ToStringBuilder toStringHelper() {
Review Comment:
I'm wondering if this is safe and you are sure that
`AbstractFetchShuffleBlocks` is not referenced by any case outside of Apache
Spark? What about `Apache Celeborn` or `Apache Uniffle`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
