dongjoon-hyun commented on code in PR #53365:
URL: https://github.com/apache/spark/pull/53365#discussion_r2595674892
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/checkpointing/OffsetSeq.scala:
##########
@@ -110,11 +107,25 @@ object OffsetSeq {
* Returns a [[OffsetSeq]] with metadata and a variable sequence of offsets.
* `nulls` in the sequence are converted to `None`s.
*/
- def fill(metadata: Option[String], offsets: OffsetV2*): OffsetSeq = {
- OffsetSeq(offsets.map(Option(_)), metadata.map(OffsetSeqMetadata.apply))
+ def fill(metadataOpt: Option[String], offsets: OffsetV2*): OffsetSeq = {
+ OffsetSeq(offsets.map(Option(_)), metadataOpt.map(OffsetSeqMetadata.apply))
+ }
+
+ /**
+ * Returns a [[OffsetSeqV2]] with metadata and a variable sequence of
offsets.
+ * `nulls` in the sequence are converted to `None`s.
+ */
+ def fillV2(metadata: Option[String], offsets: OffsetV2*): OffsetSeqV2 = {
Review Comment:
To be consist with `fill` method, this should be `metadataOpt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
