gaogaotiantian commented on PR #53359: URL: https://github.com/apache/spark/pull/53359#issuecomment-3623733831
I updated the comments, let's see if it's clearer. The rational behind this is - when we change something on the protocol (passing an extra integer at a random place, which is what we often do now), it's common to just "stuck" at somewhere. The test hangs and we don't know what happened - we don't even know where the message might go wrong. Having sanity check in different places in our protocols can stop the communication early so we know the message is already wrong at this place. It's helpful for debugging. More than that, there could be communication errors during production (rare, but possible). There could be dark corners that we forgot to test. Raising an error explicitly is always better than hanging there. That's why I think we should introduce more sanity check and real runtime validation checks on our data passed in. Of course, eventually we might just want a more dedicated RPC, but for now this is helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
