pan3793 commented on code in PR #53371:
URL: https://github.com/apache/spark/pull/53371#discussion_r2598293732
##########
sql/connect/client/jdbc/src/test/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectJdbcDataTypeSuite.scala:
##########
@@ -442,6 +442,11 @@ class SparkConnectJdbcDataTypeSuite extends
ConnectFunSuite with RemoteSparkSess
assert(bytes.length === testBytes.length)
assert(bytes.sameElements(testBytes))
assert(!rs.wasNull)
+
+ val stringValue = rs.getString(1)
+ val expectedString = new String(testBytes,
java.nio.charset.StandardCharsets.UTF_8)
Review Comment:
prefer to import it at the beginning, though there are many anti-patterns
here, maybe you can change them in bulk ...
```
import java.nio.charset.StandardCharsets
...
val expectedString = new String(testBytes, StandardCharsets.UTF_8)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
