Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r32069873
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +314,35 @@ final class ShuffleBlockFetcherIterator(
}
}
+// Helper class that ensures a ManagerBuffer is released upon
InputStream.close()
+private class WrappedInputStream(delegate: InputStream, iterator:
ShuffleBlockFetcherIterator)
--- End diff --
What about renaming this to BufferReleasingInputStream or similar? I'm
concerned that there are a bunch of other classes in Spark that are a wrapped
input stream, so specificity in the class name is helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
