cloud-fan commented on code in PR #53276: URL: https://github.com/apache/spark/pull/53276#discussion_r2601677171
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownVariantExtractions.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.read; + +import org.apache.spark.annotation.Experimental; + +/** + * A mix-in interface for {@link ScanBuilder}. Data sources can implement this interface to + * support pushing down variant field extraction operations to the data source. + * <p> + * When variant columns are accessed with specific field extractions (e.g., variant_get, + * try_variant_get), the optimizer can push these extractions down to the data source. + * The data source can then read only the required fields from variant columns, reducing + * I/O and improving performance. + * <p> + * Each {@link VariantExtraction} in the input array represents one field extraction operation. + * Data sources should examine each extraction and determine which ones can be handled efficiently. + * The return value is a boolean array of the same length, where each element indicates whether + * the corresponding extraction was accepted. + * + * @since 4.1.0 + */ +@Experimental +public interface SupportsPushDownVariantExtractions extends ScanBuilder { + + /** + * Pushes down variant field extractions to the data source. + * <p> + * Each element in the input array represents one field extraction operation from a variant + * column. Data sources should examine each extraction and determine whether it can be Review Comment: Does Spark do any reconciliation? e.g. `variant_get(v, '$.a', 'int')` and `variant_get(v, '$.b', 'int')` will be two extractions, but how about `variant_get(v, '$.a', 'struct<x int, y int>')` and `variant_get(v, '$.a.x', 'int')`? Are they two extractions as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
