srielau commented on code in PR #53407:
URL: https://github.com/apache/spark/pull/53407#discussion_r2603749855
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala:
##########
@@ -575,14 +575,14 @@ class SparkSqlAstBuilder extends AstBuilder {
ctx.op.getType match {
case SqlBaseParser.ADD =>
- ctx.identifier.getText.toLowerCase(Locale.ROOT) match {
+ getIdentifierText(ctx.identifier).toLowerCase(Locale.ROOT) match {
case "files" | "file" => AddFilesCommand(maybePaths)
case "jars" | "jar" => AddJarsCommand(maybePaths)
case "archives" | "archive" => AddArchivesCommand(maybePaths)
case other => operationNotAllowed(s"ADD with resource type
'$other'", ctx)
}
case SqlBaseParser.LIST =>
- ctx.identifier.getText.toLowerCase(Locale.ROOT) match {
+ getIdentifierText(ctx.identifier()).toLowerCase(Locale.ROOT) match {
Review Comment:
keywords
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala:
##########
@@ -735,7 +735,7 @@ class SparkSqlAstBuilder extends AstBuilder {
*/
override def visitCreateFunction(ctx: CreateFunctionContext): LogicalPlan =
withOrigin(ctx) {
val resources = ctx.resource.asScala.map { resource =>
- val resourceType = resource.identifier.getText.toLowerCase(Locale.ROOT)
+ val resourceType =
getIdentifierText(resource.identifier).toLowerCase(Locale.ROOT)
Review Comment:
keywords
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
