zifeif2 commented on code in PR #53287: URL: https://github.com/apache/spark/pull/53287#discussion_r2604289252
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala: ########## @@ -180,7 +180,7 @@ class RocksDB( @volatile private var db: NativeRocksDB = _ @volatile private var changelogWriter: Option[StateStoreChangelogWriter] = None - private val enableChangelogCheckpointing: Boolean = conf.enableChangelogCheckpointing + @volatile private var enableChangelogCheckpointing: Boolean = conf.enableChangelogCheckpointing Review Comment: because we need to change it in `load()` depending if loadEmpty is true or false. See `enableChangelogCheckpointing = if (loadEmpty) false else conf.enableChangelogCheckpointing` line 746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
