wjszlachta-man commented on PR #53306:
URL: https://github.com/apache/spark/pull/53306#issuecomment-3637147510

   @gaogaotiantian let me know what you think re. latest commit - it will check 
for errors in both `accumulators.py` and `daemon.py`.
   
   I also removed try/catch around:
   ```
   try:
       ready_fds = select.select([0, listen_sock], [], [], 1)[0]
   except select.error as ex:
       if ex[0] == EINTR:
           continue
       else:
           raise
   ```
   in `daemon.py` as this is old code and only needed for Python <3.5 (see: 
https://peps.python.org/pep-0475/ - from Python 3.5 onward `select.select()` 
will automatically retry system calls on with `EINTR`).
   
   Considering `python_requires=">=3.9"` as for Spark>=4, it should be safe to 
remove.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to