ruanwenjun commented on code in PR #53307:
URL: https://github.com/apache/spark/pull/53307#discussion_r2608849397
##########
resource-managers/kubernetes/core/volcano/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala:
##########
@@ -16,15 +16,20 @@
*/
package org.apache.spark.deploy.k8s.features
+import com.fasterxml.jackson.databind.ObjectMapper
+import com.fasterxml.jackson.dataformat.yaml.YAMLFactory
import io.fabric8.kubernetes.api.model._
import io.fabric8.volcano.api.model.scheduling.v1beta1.{PodGroup, PodGroupSpec}
import io.fabric8.volcano.client.DefaultVolcanoClient
+import org.apache.spark.SparkException
import org.apache.spark.deploy.k8s.{KubernetesConf, KubernetesDriverConf,
KubernetesExecutorConf, SparkPod}
import org.apache.spark.internal.Logging
-private[spark] class VolcanoFeatureStep extends
KubernetesDriverCustomFeatureConfigStep
- with KubernetesExecutorCustomFeatureConfigStep with Logging {
+private[spark] class VolcanoFeatureStep
+ extends KubernetesDriverCustomFeatureConfigStep
+ with KubernetesExecutorCustomFeatureConfigStep
+ with Logging {
Review Comment:
Done
##########
resource-managers/kubernetes/core/volcano/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala:
##########
@@ -42,13 +47,15 @@ private[spark] class VolcanoFeatureStep extends
KubernetesDriverCustomFeatureCon
override def getAdditionalPreKubernetesResources(): Seq[HasMetadata] = {
if (kubernetesConf.isInstanceOf[KubernetesExecutorConf]) {
- logWarning("VolcanoFeatureStep#getAdditionalPreKubernetesResources() is
not supported " +
- "for executor.")
+ logWarning(
+ "VolcanoFeatureStep#getAdditionalPreKubernetesResources() is not
supported " +
+ "for executor.")
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
