Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6726#discussion_r32073962
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/commands.scala ---
@@ -218,24 +218,20 @@ private[sql] case class InsertIntoHadoopFsRelation(
val partitionProj = newProjection(codegenEnabled, partitionOutput,
output)
val dataProj = newProjection(codegenEnabled, dataOutput, output)
- if (needsConversion) {
- val converter =
CatalystTypeConverters.createToScalaConverter(dataSchema)
- while (iterator.hasNext) {
- val row = iterator.next()
- val partitionPart = partitionProj(row)
- val dataPart = dataProj(row)
- val convertedDataPart = converter(dataPart).asInstanceOf[Row]
-
writerContainer.outputWriterForRow(partitionPart).write(convertedDataPart)
- }
+ val partitionSchema = StructType.fromAttributes(partitionOutput)
+ val partConverter =
CatalystTypeConverters.createToScalaConverter(partitionSchema)
--- End diff --
In the old code, it looks like we'd only create a converter from the
`partitionSchema` in cases where `needsConversion` was `false`, but here it
looks like we do it in both cases. Can you explain why you made this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
