gaogaotiantian commented on code in PR #53391: URL: https://github.com/apache/spark/pull/53391#discussion_r2612838637
########## python/pyspark/sql/tests/test_interchange.py: ########## @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +import unittest +import pyarrow as pa +import pandas as pd +import pyspark.pandas as ps + +try: + import duckdb + + DUCKDB_TESTS = True +except ImportError: + DUCKDB_TESTS = False Review Comment: `DUCKDB_TESTS` should be in `pyspark/testing/utils.py` and conform to the other library checkers. ########## python/pyspark/sql/tests/test_interchange.py: ########## @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +import unittest +import pyarrow as pa +import pandas as pd +import pyspark.pandas as ps + +try: + import duckdb + + DUCKDB_TESTS = True +except ImportError: + DUCKDB_TESTS = False + + [email protected](not DUCKDB_TESTS, "duckdb is not installed") Review Comment: Is the only way to test this with `duckdb`? We are introducing a new library just to test a feature. If it implements an arrow protocol, shouldn't we just be able to test with arrow or something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
