LuciferYang commented on code in PR #53453:
URL: https://github.com/apache/spark/pull/53453#discussion_r2617807422
##########
core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala:
##########
@@ -83,6 +85,11 @@ abstract class BenchmarkBase {
def suffix: String = ""
+ /**
+ * Any code before running any benchmark, e.g., data preparation
+ */
+ def beforeAll(): Unit = {}
Review Comment:
My suggestion is not to add the `beforeAll()` method in the current pr If we
find it to be widely applicable, we can add this method in a subsequent pr and
also extract `beforeAll()` for more microbenchmark scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
