devin-petersohn commented on code in PR #53478:
URL: https://github.com/apache/spark/pull/53478#discussion_r2623524810
##########
python/pyspark/pandas/frame.py:
##########
@@ -11141,9 +11141,12 @@ def all(
return self._result_aggregated(column_labels, applied)
- # TODO(SPARK-46166): axis and **kwargs should be implemented.
def any(
- self, axis: Axis = 0, bool_only: Optional[bool] = None, skipna: bool =
True
+ self,
+ axis: Optional[Axis] = 0,
+ bool_only: Optional[bool] = None,
+ skipna: bool = True,
+ **kwargs: Any,
Review Comment:
`kwargs` are only there for numpy compatibility and do not change behavior.
From pandas and the docstring in this PR:
```
**kwargs: Any, default None
Additional keywords have no effect but might be accepted for
compatibility with
NumPy.
```
Do we need a test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
