sahilkumarsingh commented on code in PR #53390:
URL: https://github.com/apache/spark/pull/53390#discussion_r2625384472
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala:
##########
@@ -1395,7 +1395,7 @@ class PlanParserSuite extends AnalysisTest {
checkError(
exception = parseException(sql2),
condition = "PARSE_SYNTAX_ERROR",
- parameters = Map("error" -> "'IN'", "hint" -> ""))
+ parameters = Map("error" -> "'INTO'", "hint" -> ""))
Review Comment:
Hey Allison,
This is the before and after this change for this test case:
Before:
```
[scala> spark.sql("SELECT * FROM S WHERE C1 IN (INSERT INTO T VALUES
(2))").show()
org.apache.spark.sql.catalyst.parser.ParseException:
[PARSE_SYNTAX_ERROR] Syntax error at or near 'IN'. SQLSTATE: 42601 (line 1,
pos 25)
== SQL ==
SELECT * FROM S WHERE C1 IN (INSERT INTO T VALUES (2))
-------------------------^^^
at
org.apache.spark.sql.catalyst.parser.ParseException.withCommand(parsers.scala:285)
at
org.apache.spark.sql.catalyst.parser.AbstractParser.parse(parsers.scala:97)
at
org.apache.spark.sql.execution.SparkSqlParser.parse(SparkSqlParser.scala:54)
at
org.apache.spark.sql.catalyst.parser.AbstractSqlParser.parsePlan(AbstractSqlParser.scala:93)
at
org.apache.spark.sql.classic.SparkSession.$anonfun$sql$5(SparkSession.scala:492)
at
org.apache.spark.sql.catalyst.QueryPlanningTracker.measurePhase(QueryPlanningTracker.scala:148)
at
org.apache.spark.sql.classic.SparkSession.$anonfun$sql$4(SparkSession.scala:491)
at org.apache.spark.sql.SparkSession.withActive(SparkSession.scala:804)
at org.apache.spark.sql.classic.SparkSession.sql(SparkSession.scala:490)
at org.apache.spark.sql.classic.SparkSession.sql(SparkSession.scala:504)
at org.apache.spark.sql.classic.SparkSession.sql(SparkSession.scala:513)
at org.apache.spark.sql.classic.SparkSession.sql(SparkSession.scala:91)
... 42 elided
```
After:
```
[scala> spark.sql("SELECT * FROM S WHERE C1 IN (INSERT INTO T VALUES
(2))").show()
org.apache.spark.sql.catalyst.parser.ParseException:
[PARSE_SYNTAX_ERROR] Syntax error at or near 'INTO'. SQLSTATE: 42601 (line
1, pos 36)
== SQL ==
SELECT * FROM S WHERE C1 IN (INSERT INTO T VALUES (2))
------------------------------------^^^
at
org.apache.spark.sql.catalyst.parser.ParseException.withCommand(parsers.scala:267)
at
org.apache.spark.sql.catalyst.parser.AbstractParser.parse(parsers.scala:78)
at
org.apache.spark.sql.execution.SparkSqlParser.super$parse(SparkSqlParser.scala:163)
at
org.apache.spark.sql.execution.SparkSqlParser.$anonfun$parseInternal$1(SparkSqlParser.scala:163)
at
org.apache.spark.sql.catalyst.trees.CurrentOrigin$.withOrigin(origin.scala:107)
at
org.apache.spark.sql.execution.SparkSqlParser.parseInternal(SparkSqlParser.scala:163)
at
org.apache.spark.sql.execution.SparkSqlParser.parseWithParameters(SparkSqlParser.scala:70)
at
org.apache.spark.sql.execution.SparkSqlParser.parsePlanWithParameters(SparkSqlParser.scala:84)
at
org.apache.spark.sql.classic.SparkSession.$anonfun$sql$6(SparkSession.scala:573)
at
org.apache.spark.sql.catalyst.QueryPlanningTracker.measurePhase(QueryPlanningTracker.scala:148)
at
org.apache.spark.sql.classic.SparkSession.$anonfun$sql$4(SparkSession.scala:572)
at org.apache.spark.sql.SparkSession.withActive(SparkSession.scala:804)
at org.apache.spark.sql.classic.SparkSession.sql(SparkSession.scala:563)
at org.apache.spark.sql.classic.SparkSession.sql(SparkSession.scala:591)
at org.apache.spark.sql.classic.SparkSession.sql(SparkSession.scala:682)
at org.apache.spark.sql.classic.SparkSession.sql(SparkSession.scala:92)
... 42 elided
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
