qlong commented on code in PR #53468:
URL: https://github.com/apache/spark/pull/53468#discussion_r2625490446
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -4094,8 +4094,14 @@ trait ArraySetLike {
case _ => false
}
- @transient protected lazy val ordering: Ordering[Any] =
- TypeUtils.getInterpretedOrdering(et)
+ // If the element type supports proper equals, we use the values directly
for comparison,
+ // otherwise we use the generic comparable wrapper so all types support
hash-based operations
Review Comment:
Question: GenericComparableWrapper also works with simple types like Int?
Use identity is more for performance reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
