zifeif2 commented on code in PR #53316:
URL: https://github.com/apache/spark/pull/53316#discussion_r2628380815
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -184,6 +184,13 @@ trait ReadStateStore {
* This method is idempotent and safe to call multiple times.
*/
def release(): Unit
+
+ /**
+ * Returns all column family names in this state store.
+ *
+ * @return Set of all column family names
+ */
+ def allColumnFamilyNames: Set[String]
Review Comment:
Ok! Added an assertion in RocksDBSuite after where it contains multiple
column families. Didn't create a new test though because RocksDBSuite might be
too big already
For the operator level, I looked at TransformWithStateSuite but don't think
it's directly accessing the underlying DB to call allColumnFamilyNames. Given
that RocksDBSuite already covers the case of having multiple col family, do
you think it's okay to not add a test at operator level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
