cloud-fan commented on code in PR #53523:
URL: https://github.com/apache/spark/pull/53523#discussion_r2630311938
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -807,7 +807,15 @@ case class AdaptiveSparkPlanExec(
// node to prevent the loss of the `BroadcastExchangeExec` node in DPP
subquery.
// Here, we also need to avoid to insert the `BroadcastExchangeExec`
node when the newPlan is
// already the `BroadcastExchangeExec` plan after apply the
`LogicalQueryStageStrategy` rule.
- val finalPlan = inputPlan match {
+ val finalPlan = currentPhysicalPlan match {
+ case broadcastQueryStage@BroadcastQueryStageExec(_, broadcast, _)
Review Comment:
do we have a test or a explanation about how this can happen? The comment
above says the broadcast maybe added by DPP and it shouldn't have
`BroadcastQueryStageExec`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
