pan3793 commented on code in PR #53531:
URL: https://github.com/apache/spark/pull/53531#discussion_r2632280388
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSessionCatalogSuite.scala:
##########
@@ -79,4 +79,11 @@ class DataSourceV2SQLSessionCatalogSuite
assert(getTableMetadata("default.t").columns().map(_.name()) ===
Seq("c2", "c1"))
}
}
+
+ test("DelegatingCatalogExtension supports both V1 and V2 functions") {
+ sessionCatalog.createFunction(Identifier.of(Array("ns"), "strlen"),
StrLen(StrLenDefault))
+ checkAnswer(
+ sql("SELECT char_length('Hello') as v1, ns.strlen('Spark') as v2"),
+ Row(5, 5))
Review Comment:
it's the effective test case, previously it could not load the v2 func
`ns.strlen`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
