yhuang-db commented on code in PR #53532:
URL: https://github.com/apache/spark/pull/53532#discussion_r2633233778
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -128,6 +128,25 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
case DropColumns(ResolvedV1TableIdentifier(ident), _, _) =>
throw QueryCompilationErrors.unsupportedTableOperationError(ident, "DROP
COLUMN")
+ // V1 and hive tables do not support constraints
+ case AddConstraint(ResolvedV1TableIdentifier(ident), _) =>
+ throw QueryCompilationErrors.unsupportedTableOperationError(ident, "ADD
CONSTRAINT")
+
+ case DropConstraint(ResolvedV1TableIdentifier(ident), _, _, _) =>
+ throw QueryCompilationErrors.unsupportedTableOperationError(ident, "DROP
CONSTRAINT")
+
+ case a: AddCheckConstraint
Review Comment:
> I found
[ResolveTableConstraints](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveTableConstraints.scala)
which looks like should have done the job. Will take another look on that
later.
That validates on TableCatalogCapability capability. It didn't check the
catalog type.
Thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
