cloud-fan commented on code in PR #53488: URL: https://github.com/apache/spark/pull/53488#discussion_r2638748681
########## common/config/src/main/resources/org/apache/spark/config/session_configs/sql.textproto: ########## Review Comment: See https://github.com/apache/spark/pull/53488/files#diff-82e9b261f86d3cbd94a23abe94aadf45531e0b29603082336784e30ea46c9574R108-R116 We can override certain fields of the config definition at the Scala side, and default value can be supported as well. For enum conf, one benefit is that it's type safe: the `getConf` API returns the enum instance directly. This means we need a `ConfigEntry` at the Scala side, but we can still define the enum in protobuf, and expose the protobuf enum. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
