cloud-fan commented on code in PR #53406:
URL: https://github.com/apache/spark/pull/53406#discussion_r2642298701
##########
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala:
##########
@@ -229,6 +238,7 @@ class HadoopMapReduceCommitProtocol(
}
fs.delete(stagingDir, true)
+ fs.cancelDeleteOnExit(stagingDir)
Review Comment:
let's add a code comment to explain it. It's not intuitive that we need to
cancel it to avoid memory leak, even if the directory has been deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
