mihailoale-db commented on code in PR #53577:
URL: https://github.com/apache/spark/pull/53577#discussion_r2645125968
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -952,32 +952,7 @@ class Analyzer(
// TypeCoercionBase.UnpivotCoercion determines valueType
// and casts values once values are set and resolved
case Unpivot(Some(ids), Some(values), aliases, variableColumnName,
valueColumnNames, child) =>
-
Review Comment:
This is the main one. The other ones are just populating empty spots so we
get the `Unpivot` that's going to be handled by this case. And also those are
3lines long so I assumed that refactoring the main + the biggest one would make
sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
