cloud-fan commented on code in PR #53530:
URL: https://github.com/apache/spark/pull/53530#discussion_r2646485672
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -6573,6 +6575,100 @@ class AstBuilder extends DataTypeAstBuilder
)
}
+ /**
+ * Create a [[DeclareCursor]] command wrapped in SingleStatement.
+ *
+ * For example:
+ * {{{
+ * DECLARE cursor_name CURSOR FOR SELECT * FROM table;
+ * }}}
+ */
+ override def visitDeclareCursorStatement(
+ ctx: DeclareCursorStatementContext): LogicalPlan = withOrigin(ctx) {
+ val cursorName = ctx.strictIdentifier().getText
+ // Extract original SQL text to preserve parameter markers
+ val queryText = getOriginalText(ctx.query())
+
+ // Use a placeholder plan (LocalRelation) - the actual query will be
parsed at execution time
+ // This prevents parameter markers from being resolved during script
analysis
+ val query: LogicalPlan = LocalRelation()
+
+ val asensitive = ctx.ASENSITIVE() != null || ctx.INSENSITIVE() != null
+ SingleStatement(DeclareCursor(cursorName, query, queryText, asensitive))
+ }
+
+ /**
+ * Create an [[OpenCursor]] command wrapped in SingleStatement.
+ *
+ * For example:
+ * {{{
+ * OPEN cursor_name;
+ * OPEN cursor_name USING expr1, expr2;
+ * OPEN cursor_name USING (expr1 AS param1, expr2 AS param2);
+ * }}}
+ */
+ override def visitOpenCursorStatement(
+ ctx: OpenCursorStatementContext): LogicalPlan = withOrigin(ctx) {
+ val cursorName =
ctx.multipartIdentifier().parts.asScala.map(_.getText).mkString(".")
+
+ // Parse optional USING clause parameters
+ // Extract both expressions and their names (if aliased)
+ val (args, paramNames) = Option(ctx.params).map { params =>
+ val namedExprs =
params.namedExpression().asScala.toSeq.map(visitNamedExpression)
+ val exprs = namedExprs.map {
+ case alias: Alias => alias.child // Extract child expression
+ case expr => expr
+ }
+ val names = namedExprs.map {
+ case alias: Alias => alias.name // Extract alias name
+ case _ => "" // Positional parameter (no name)
+ }
+ (exprs, names)
Review Comment:
nit:
```
namedExprs.map {
case alias: Alias => (alias.child, alias.name)
case expr => (expr, "")
}.unzip2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
