pan3793 commented on code in PR #53437:
URL: https://github.com/apache/spark/pull/53437#discussion_r2647648523
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/command/DescribeProcedureCommand.scala:
##########
@@ -45,34 +42,63 @@ case class DescribeProcedureCommand(
override def run(sparkSession: SparkSession): Seq[Row] = {
child match {
- case ResolvedIdentifier(catalog, ident) =>
- val procedure = load(catalog.asProcedureCatalog, ident)
- describeV2Procedure(procedure)
+ case ResolvedProcedure(catalog, ident, procedure) =>
+ describeV2Procedure(procedure.asInstanceOf[UnboundProcedure])
case _ =>
throw SparkException.internalError(s"Invalid procedure identifier:
${child.getClass}")
}
}
- private def load(catalog: ProcedureCatalog, ident: Identifier):
UnboundProcedure = {
- try {
- catalog.loadProcedure(ident)
- } catch {
- case e: Exception if !e.isInstanceOf[SparkThrowable] =>
- val nameParts = catalog.name +: ident.asMultipartIdentifier
- throw QueryCompilationErrors.failedToLoadRoutineError(nameParts, e)
- }
- }
private def describeV2Procedure(procedure: UnboundProcedure): Seq[Row] = {
val buffer = new ArrayBuffer[(String, String)]
append(buffer, "Procedure:", procedure.name())
append(buffer, "Description:", procedure.description())
+ // UnboundProcedure requires binding to retrieve parameters. We try to
bind with an empty
+ // argument list to get the parameters. If the procedure requires
arguments, binding might
+ // fail. In that case, we suppress the exception and just show the
procedure metadata
+ // without parameters.
Review Comment:
I understand it's a best effort approach, but I can imagine if we do it in
the current way, we will get many questions from users - why DESCRIBE does not
show parameters for some procedures.
for functions, it relies on a description to provide the args info. I prefer
this way given the situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
