cloud-fan commented on code in PR #53579:
URL: https://github.com/apache/spark/pull/53579#discussion_r2649414032
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/test/TestHiveSingleton.scala:
##########
@@ -17,15 +17,16 @@
package org.apache.spark.sql.hive.test
-import org.scalatest.BeforeAndAfterAll
-
-import org.apache.spark.SparkFunSuite
+import org.apache.spark.{SparkFunSuite, SparkTestSuite}
import org.apache.spark.sql.classic.SparkSession
import org.apache.spark.sql.hive.HiveExternalCatalog
import org.apache.spark.sql.hive.client.HiveClient
+import org.apache.spark.sql.test.SparkSessionProvider
+
+trait TestHiveSingleton extends SparkFunSuite with TestHiveSingletonBase
-trait TestHiveSingleton extends SparkFunSuite with BeforeAndAfterAll {
+trait TestHiveSingletonBase extends SparkTestSuite with SparkSessionProvider {
Review Comment:
this may be useful, but let's not create new `XXXBase` test helps in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
