cloud-fan commented on code in PR #53643:
URL: https://github.com/apache/spark/pull/53643#discussion_r2652744133
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ApplyDefaultCollation.scala:
##########
@@ -103,13 +124,12 @@ object ApplyDefaultCollationToStringType extends
Rule[LogicalPlan] {
* Determines the default collation for an object in the following order:
* 1. Use the object's explicitly defined default collation, if available.
* 2. Otherwise, use the default collation defined by the object's schema.
Review Comment:
```suggestion
* 2. Otherwise, use the default collation defined by the object's schema.
* 3. If not defined in the schema, use the default collation from the
object's catalog.
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ApplyDefaultCollation.scala:
##########
@@ -103,13 +124,12 @@ object ApplyDefaultCollationToStringType extends
Rule[LogicalPlan] {
* Determines the default collation for an object in the following order:
* 1. Use the object's explicitly defined default collation, if available.
* 2. Otherwise, use the default collation defined by the object's schema.
- * 3. If not defined in the schema, use the default collation from the
object's catalog.
*
* If none of these collations are specified, None will be persisted as the
default collation,
* which means the system default collation `UTF8_BINARY` will be used and
the plan will not be
* changed.
* This function applies to DDL commands. An object's default collation is
persisted at the moment
- * of its creation, and altering the schema or catalog collation will not
affect existing objects.
+ * of its creation, and altering the schema collation will not affect
existing objects.
Review Comment:
```suggestion
* of its creation, and altering the schema collation or catalog will not
affect existing objects.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
