cloud-fan commented on code in PR #53631:
URL: https://github.com/apache/spark/pull/53631#discussion_r2652893305
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala:
##########
@@ -197,16 +197,6 @@ abstract class SessionCatalogSuite extends AnalysisTest
with Eventually {
"expectedType" -> "\"BOOLEAN\"",
"defaultValue" -> "41 + 1",
"actualType" -> "\"INT\""))
-
- // Make sure that constant-folding default values does not take place
when the feature is
- // disabled.
Review Comment:
When feature is disabled, default value is empty. The default constant
folding doesn't need to check the conf again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
