cloud-fan commented on code in PR #53644:
URL: https://github.com/apache/spark/pull/53644#discussion_r2655349534
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -755,6 +755,7 @@ class Analyzer(
groupByExprs: Seq[Expression],
aggregationExprs: Seq[NamedExpression],
child: LogicalPlan): LogicalPlan = {
+ val aggregationExpressionsWithoutAliases =
aggregationExprs.map(trimNonTopLevelAliases)
Review Comment:
the name seems too long, how about `aggExprsNoAlias`
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/grouping.scala:
##########
@@ -267,24 +267,26 @@ object GroupingID {
}
}
-object GroupingAnalytics {
+object GroupingAnalytics extends AliasHelper {
def unapply(exprs: Seq[Expression])
: Option[(Seq[Seq[Expression]], Seq[Expression])] = {
- if (!exprs.exists(_.isInstanceOf[BaseGroupingSets])) {
+ val expressionsWithoutAliases = exprs.map(trimAliases)
Review Comment:
ditto, `exprsNoAlias`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
