viirya commented on code in PR #272:
URL:
https://github.com/apache/spark-connect-swift/pull/272#discussion_r2659435323
##########
Sources/SparkConnect/ArrowType.swift:
##########
@@ -412,6 +426,20 @@ public class ArrowType {
return "z"
case ArrowTypeId.string:
return "u"
+
+ if let structType = self as? ArrowTypeStruct {
Review Comment:
I wonder why this `if let structType = self as? ArrowTypeStruct {` is after
above `return "u"` for string type? Shouldn't there be `case
ArrowTypeId.struct:`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
