ivoson commented on code in PR #53652:
URL: https://github.com/apache/spark/pull/53652#discussion_r2660498340
##########
docs/sql-migration-guide.md:
##########
@@ -22,6 +22,10 @@ license: |
* Table of contents
{:toc}
+## Upgrading from Spark SQL 4.1 to 4.2
+
+- Since Spark 4.2, Spark enables order-independent checksums for shuffle
outputs by default to detect data inconsistencies during indeterminate shuffle
stage retries. If a checksum mismatch is detected, Spark rolls back and
re-executes all succeeding stages that depend on the shuffle output. If rolling
back is not possible for some succeeding stages, the job will fail. To restore
the previous behavior, set `spark.sql.shuffle.orderIndependentChecksum.enabled`
and `spark.sql.shuffle.orderIndependentChecksum.enableFullRetryOnMismatch` to
`false`.
Review Comment:
It would be better to set both to `false`.
Since the second one controls the behavior whether we depend on checksum to
detect indeterminate shuffle retry, and the first one decide whether we'll
compute checksum for shuffle output.
Only disable the 1st one, we'll never detect the indeterminate shuffle retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
